Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Parsing component and replace them in starter projects #6697

Merged
merged 35 commits into from
Mar 31, 2025

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes changes to mark certain components as legacy and format JSON files for better readability. The most important changes include setting the legacy attribute to True for specific components and formatting the Blog Writer.json file.

Marking components as legacy:

Formatting JSON files:

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 18, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

To be merged after:
#6642 #6652
#6302

Templates to b updated once these PRs are Merged.

Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #6697 will degrade performances by 27.44%

Comparing deprecate-parsing-components (c1114f4) with fix/parser_component (bc04db6)

Summary

❌ 1 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 9 ms 12.4 ms -27.44%

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if we switch the legacy components for the new components in the starter projects

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2025
@carlosrcoelho carlosrcoelho requested review from lucaseduoli and removed request for lucaseduoli March 5, 2025 13:47
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 25, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

On testing found a bug in new parser component:

data_to_text : test portfolio website generator.

@edwinjosechittilappilly
Copy link
Collaborator Author

@Cristhianzl @erichare @mendonk
Few of templates are getting updated here since a new parser component is being used instead of deprecated ones.

Looking forward to your support for review.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 28, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 28, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 30, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 31, 2025
Base automatically changed from fix/parser_component to main March 31, 2025 16:13
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 31, 2025
@italojohnny italojohnny enabled auto-merge March 31, 2025 16:14
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 31, 2025
@italojohnny italojohnny removed the DO NOT MERGE Don't Merge this PR label Mar 31, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

@Cristhianzl

…clude legacy components in the test scenario

🔧 (decisionFlow.spec.ts): increase timeout from 500ms to 2000ms for better stability and reliability in waiting for selectors to appear
@Cristhianzl Cristhianzl disabled auto-merge March 31, 2025 16:47
@Cristhianzl Cristhianzl merged commit 017a0a4 into main Mar 31, 2025
9 of 10 checks passed
@Cristhianzl Cristhianzl deleted the deprecate-parsing-components branch March 31, 2025 16:57
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 31, 2025
QDDCoder pushed a commit to QDDCoder/langflow that referenced this pull request Apr 1, 2025
* commit '6c2ff92ccf083f038d9a97a749b4e0f30a60247a': (255 commits)
  docs: Update documentation and add TAVILY_API_KEY to environment variables (langflow-ai#7366)
  docs: mcp server component and integrations (langflow-ai#7286)
  docs: v1.3 (langflow-ai#7160)
  chore(deps-dev): bump vite from 5.4.14 to 5.4.16 in /src/frontend (langflow-ai#7365)
  fix: add secret key loading functionality to basic templates (langflow-ai#7363)
  docs: platform content (langflow-ai#7091)
  chore: bump langflow and langflow-base for 1.3.0 release (langflow-ai#7362)
  docs: ensure asset paths update on draft rebuilds (langflow-ai#7355)
  fix: Prevent API key banner from displaying when key is unavailable (langflow-ai#7356)
  fix: MCP SSE Model tool mode issue (langflow-ai#7360)
  feat: deprecate Parsing component and replace them in starter projects (langflow-ai#6697)
  fix: fixed the parser component (langflow-ai#7303)
  ref: split ast parsing / class exec loops (langflow-ai#7248)
  feat: Update AgentQL templates (langflow-ai#7165)
  feat: add a unified local vector store (langflow-ai#6995)
  fix: update currentflow to be fetched from Flow Store for icon to be rendered correctly (langflow-ai#7354)
  feat: expose serialization truncation constants in /config route (langflow-ai#7316)
  feat: lmprove MCP langflow port selection and error handling (langflow-ai#7327)
  fix: adds priority sorting for sidebar components and makes LanguageModel appear first (langflow-ai#7322)
  fix: make agent work with new tool mode backend updates (langflow-ai#7314)
  ...

# Conflicts:
#	src/frontend/src/utils/styleUtils.ts

更新到V1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants